Add --work-path and --custom-path to git hooks

[DavidGregory084]

Fixes #25107.

This adds explicit --work-path and --custom-path flags to the generated git hooks.

This should prevent hooks from inheriting different values for AppWorkPath and CustomPath than those used in the main gitea process.

[delvh]

Hmm… I'm not quite sure how similar this is to #22754, especially if the same discussion still applies.

[DavidGregory084]

Hmm that is an interesting discussion.

The root of this entire problem seems to be that the app.ini is not authoritative.

There are too many Gitea entry points in a single deployment to allow command-line and environment variable overrides that affect something fundamental like the working directories.

In the case of the snap package, this manifests itself in the form of hardcoded environment variables in snapcraft.yml that make it difficult for users to override the default paths consistently throughout the application.

I guess that runs counter to the 12-Factor-App philosophy, but the alternative is that the environment and command line flags are propagated consistently to any entry points.

[lunny]

Maybe we should store them into some runtime files and share for different processes. Otherwise everytime, the paths changed, we need to update all the repositories which will take too much time for a big instance. Or store them into database or memory for internal route endpoint.

[wxiaoguang]

We shouldn't do this. There are more problems for these "config options".

• Refactor path system #24818

I will fix the path problem in 1.21 (I do not want to introduce too many breaking changes in 1.20 since it is releasing soon)

[DavidGregory084]

Yeah I just read #24818 and I agree that it's a much better solution 👍