Skip to content

Show errors for KaTeX and mermaid on the preview tab (#24009) #24019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 9, 2023

Backport #24009 by @silverwind

There is a conflicting fomantic rule that hid the error messages inside the markdown preview tab for things like mermaid or katex. Overruled it to always show these errors.

image

There is a conflicting fomantic rule that hid the error messages inside
the markdown preview tab for things like mermaid or katex.
Overruled it to always show these errors.

<img width="774" alt="image"
src="https://user-images.githubusercontent.com/115237/230738528-322814c1-8994-495e-b901-bbb79b924ccb.png">
@GiteaBot GiteaBot added type/bug topic/ui Change the appearance of the Gitea UI outdated/theme/markdown labels Apr 9, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Apr 9, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 9, 2023
@silverwind silverwind enabled auto-merge (squash) April 9, 2023 12:08
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2023
@silverwind silverwind merged commit 2b10eeb into go-gitea:release/v1.19 Apr 9, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
@techknowlogick techknowlogick deleted the backport-24009-v1.19 branch September 9, 2023 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/theme/markdown topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants