Skip to content

Fix ldap configuration edit bug #18856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

Fix ldap configuration edit bug #18856

merged 2 commits into from
Feb 22, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2022

Fix #18766

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Feb 22, 2022
@lunny lunny added this to the 1.17.0 milestone Feb 22, 2022
@lunny lunny force-pushed the lunny/fix_ldap_bug branch from 781cd56 to 6816e5e Compare February 22, 2022 09:37
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 22, 2022
This was referenced Feb 22, 2022
Closed
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2022
@techknowlogick techknowlogick merged commit 2b5e013 into go-gitea:main Feb 22, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 23, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0362638 
* giteaofficial/main:
  Fix ldap edit bug (go-gitea#18856)
  Fix behavior or checkbox submission. (go-gitea#18851)
@lunny lunny deleted the lunny/fix_ldap_bug branch February 24, 2022 01:56
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @techknowlogick
Fix ldap edit bug (go-gitea#18856)
daf6f54 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@richmahn richmahn richmahn approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Ldap Admin UI looses encryption settings on save
5 participants
@lunny @lafriks @richmahn @techknowlogick @GiteaBot