Remove bsdtar #15262
Closed
Remove bsdtar #15262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdtar on ubuntu 18.04 does not support no-xattrs. This means it is unsuitable for use and is currently breaking release. This PR simply removes the bsdtar use from drone but allows users to set TAR="bsdtar --no-xattrs" in future should they wish to use that. Fix go-gitea#14578 (again) Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
skip-changelog
GiteaBot
added
the
lgtm/need 1
|
I'm apologizing again here. I wouldn't have thought it could even bork twice on CI even after many testing by then, and npm 7 was another big issue I had no idea about before. If only there were some sort of guidance on creating a similar CI workflow on my own fork (which has CI enabled on drone.io) I would have discovered these stuff long before. |
|
bsdtar removal is also included in #15273. |
|
Since two mentioned pulls are not ready jet i propose: mergebthis first & let the other pulls be followups that can be checked & reviewed without blocking things |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 8, 2021
- Don't package node_modules in tarballs, they are not cross-platform anymore and npm cache should not be messed with directly. Instead, require an internet connection to rebuild the UI, which is not necessary in the general use case because prebuilt UI files are shipped in the public directory. - Simplify the fomantic build and make the target phony. We don't need anything more for something that is rarely ran. - Use regular tar again to build tarballs and add variable for excludes - Disable annoying npm update notifications Fixes: go-gitea#14578 Fixes: go-gitea#15256 Fixes: go-gitea#15262
techknowlogick
pushed a commit
that referenced
this pull request
Apr 9, 2021
- Don't package node_modules in tarballs, they are not cross-platform anymore and npm cache should not be messed with directly. Instead, require an internet connection to rebuild the UI, which is not necessary in the general use case because prebuilt UI files are shipped in the public directory. - Simplify the fomantic build and make the target phony. We don't need anything more for something that is rarely ran. - Use regular tar again to build tarballs and add variable for excludes - Disable annoying npm update notifications Fixes: #14578 Fixes: #15256 Fixes: #15262 Co-authored-by: 6543 <6543@obermui.de>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
- Don't package node_modules in tarballs, they are not cross-platform anymore and npm cache should not be messed with directly. Instead, require an internet connection to rebuild the UI, which is not necessary in the general use case because prebuilt UI files are shipped in the public directory. - Simplify the fomantic build and make the target phony. We don't need anything more for something that is rarely ran. - Use regular tar again to build tarballs and add variable for excludes - Disable annoying npm update notifications Fixes: go-gitea#14578 Fixes: go-gitea#15256 Fixes: go-gitea#15262 Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsdtaron ubuntu 18.04 does not support--no-xattrs. This means it is unsuitable foruse and is currently breaking release.
This PR simply removes the
bsdtaruse from.drone.ymland changes the Makefile to allow users to setTAR="bsdtar --no-xattrs"in future should they wish to use that.Fix #14578 (again)
Signed-off-by: Andrew Thornton art27@cantab.net