Allow text selection in markdown rendered checkbox labels

[j2L4e]

Overrides Semantic UI styling of Checkbox labels to allow text selection in markdown rendered content.

fixes #12842

[silverwind]

There is more to this than just allowing user-select. If one starts and ends a selection on such a label some of Fomantic's JS seems to unexpectedly clear the selection probably in an ill-fated attempt to toggle the checkbox. Maybe that bevhaviour can be fixed too, but I guess it would either require digging into fomantic options or layering another JS hack on top of it.

[silverwind]

A better fix is probably to remove the ui class (making fomantic no longer interfere) from those checkboxes and implement some custom SVG-based rendering for the checkboxes itself.

[j2L4e]

Something weird is going on anyway. When you edit and save - [ ] foo, the item is rendered as this

<li class="task-list-item">
  <span class="ui checkbox">
    <input type="checkbox" readonly="readonly">
    <label>
      <p>foo</p>
    </label>
  </span>
</li>

(which works as expected, label non-clickable but selectable)

After a page refresh it renders the clickable, non selectable version

<li class="task-list-item">
  <span class="ui checkbox">
    <input type="checkbox" readonly="readonly" tabindex="0" class="hidden">   
    <label>
      <p>foo</p>
    </label>
  </span>
</li>

[j2L4e]

Changing the selection state by clicking the box doesn't seem to be workng anyway at the moment (#7097), so this seems to be at least a temporary fix for the selection issue

[silverwind]

I'll have a look later at removing the ui class. We don't really want Fomantic to interact with rendered markdown anyways.

[j2L4e]

Awesome, I'll close this one then, have a great day!

I think I'll be taking a shot at #7097 soon, mind if I ping you for that?

[silverwind]

I guess I can assist there but you should wait on the fix for this one before starting there.