Better vertical align of buttons in headers #13932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method used `transform` which formed a CSS stacking context which caused issues with dropdowns appearing behind other elements which made `position: static` necessary but that again caused even more issues. This method achieves the same as before, but without the additional stacking context.
silverwind
added
type/refactoring
zeripath
approved these changes
Dec 10, 2020
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Dec 10, 2020
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method used
transformwhich formed a CSS stacking context which caused issues with dropdowns appearing behind other elements which madeposition: staticnecessary but that again caused even more issues.This method achieves the same as before, but without the additional stacking context. There should be no actual visual change with this PR.