Add default CommitID for create pull review api #11334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user create pull review through api but not set CommitID, I think it's necessary to use last headCommitID as default seting, or this review will be considered as stale review which is wrong Signed-off-by: a1012112796 <1012112796@qq.com>
zeripath
approved these changes
May 8, 2020
GiteaBot
added
the
lgtm/need 1
|
I would move this into pull_service.CreateCodeComment ... |
I have thought about this, I didn't add it into CreateReview is because ui's Commit ID is auto added, So CommitID won't have chance to be empty. so add to api is enough, then user can gitea/templates/repo/diff/new_review.tmpl Lines 9 to 11 in 866ce12 |
6543
approved these changes
May 8, 2020
GiteaBot
added
lgtm/done
This comment has been minimized.
This comment has been minimized.
zeripath
added
the
skip-changelog
Codecov Report
@@ Coverage Diff @@
## master #11334 +/- ##
==========================================
+ Coverage 43.82% 43.84% +0.01%
==========================================
Files 613 613
Lines 87207 87221 +14
==========================================
+ Hits 38217 38238 +21
+ Misses 44277 44271 -6
+ Partials 4713 4712 -1
Continue to review full report at Codecov.
|
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
If user create pull review through api but not set CommitID, I think it's necessary to use last headCommitID as default seting, or this review will be considered as stale review which is wrong Signed-off-by: a1012112796 <1012112796@qq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user create pull review through api but not set CommitID,I think it's necessary to use last headCommitID as default seting, or this review will be considered as stale review which is wrong