Skip to content

The template parsing of the Sync fork prompt bar is abnormal in Chinese #33931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imkuang opened this issue Mar 18, 2025 · 4 comments
Closed
Labels

Comments

@imkuang
Copy link

imkuang commented Mar 18, 2025

Description

When there is a difference between the forked repo and the upstream repo, Gitea will display a Sync fork prompt.
I noticed that in some repo, there is a suspected template parsing error in the Chinese prompt, for example:

Image

If I switch the language to English the problem does not exist, I guess it might be a bug in the translation template?

Image

The problem does not seem to occur in all repositories and all branches, but I can definitely reproduce the problem by doing the following:

  1. Mirror the openwrt repo ( https://git.openwrt.org/openwrt/openwrt.git ) to an Organization
  2. Fork it to your own account
  3. Create new branch from openwrt-24.10, then you will be able to see this error on the newly created branch (remember to switch the language to Chinese)

Gitea Version

1.23.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian

How are you running Gitea?

Official Docker image

Database

SQLite

@imkuang
Copy link
Author

imkuang commented Mar 18, 2025

Maybe we should backport this translation commit: 02c64e4

@wxiaoguang The correct translation merged to main branch seems to be only a few days behind your this backport: e98dd6e
Maybe we need an additional backport?

@imkuang
Copy link
Author

imkuang commented Mar 18, 2025

The translation of the 1.23 branch did not handle the order of arguments correctly, which was fixed in the commit of the above mian branch
Image

Image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 18, 2025

Similar to this one: #32937 (comment)

It seems that no maintainer is interested to document it or regularly check the locales, so it happens again and again .....


By the way, unusually PRs with locale changes won't be backported. This "Sync fork" related PRs are special and quite important, so the PRs were backported, but the locales went wrong.

@wxiaoguang
Copy link
Contributor

-> Fix incorrect 1.23 translations #33932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants