Skip to content

actions on push branches single value not triggering #33657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aceArt-GmbH opened this issue Feb 20, 2025 · 3 comments · Fixed by #33760
Closed

actions on push branches single value not triggering #33657

aceArt-GmbH opened this issue Feb 20, 2025 · 3 comments · Fixed by #33760
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Milestone
1.23.5

Comments

@aceArt-GmbH
Copy link
Contributor

Description

Up until gitea 1.22 following action config was valid and triggert on a push to master.

name: Unit tests
on:
    push:
        branches: master

After updating to 1.23 this no longer triggers a build.

Workaround:

name: Unit tests
on:
    push:
        branches:
            - master

The "workaround" is simple and may be the (only) correct thing.
But the changelog did not mention this change, so I suspect it being a regression.
I am fine with either, but it should be fixed OR mentioned as breaking change 🙃

Gitea Version

1.23.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.47.2

Operating System

alpine lxc

How are you running Gitea?

docker compose

Database

MySQL/MariaDB
@kemzeb kemzeb added the topic/gitea-actions related to the actions of Gitea label Feb 21, 2025
@gsvd
Copy link
Contributor

gsvd commented Feb 21, 2025 •
edited
Loading

Hey, I've submitted a bug fix in this PR.
This issue is related to the gitea/act dependency.

@lunny lunny added this to the 1.23.5 milestone Feb 25, 2025
@aceArt-GmbH
Copy link
Contributor Author

Should I close this as https://gitea.com/gitea/act/pulls/129 is merged?
Or does gitea/act still need updating here?

@lunny
Copy link
Member

lunny commented Feb 26, 2025

Should I close this as https://gitea.com/gitea/act/pulls/129 is merged? Or does gitea/act still need updating here?

Both act_runner and gitea need to be updated before we can proceed with closing this issue.

@lunny lunny mentioned this issue Mar 1, 2025
Merged
lunny added a commit that referenced this issue Mar 1, 2025
@lunny
Upgrade act to 0.261.4 and actions-proto-go to v0.4.1 (#33760)
2c8bdd2 
Include https://gitea.com/gitea/act/pulls/129 Fix #33657 
And https://gitea.com/gitea/actions-proto-def/pulls/14
chhe pushed a commit to chhe/act that referenced this issue Mar 5, 2025
@gsvd @lunny
fix handle missing yaml.ScalarNode (#129)
5da4954 
This bug was reported on go-gitea/gitea#33657
Rewrite of (see below) was missing in this commit https://gitea.com/gsvd/act/commit/6cdf1e5788dbfa8fe9787a07178c28b64837a61f
```go
case string:
    acts[act] = []string{b}
```

Reviewed-on: https://gitea.com/gitea/act/pulls/129
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Guillaume S. <me@gsvd.dev>
Co-committed-by: Guillaume S. <me@gsvd.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.23.5
Development

Successfully merging a pull request may close this issue.

Upgrade act to 0.261.4 and actions-proto-go to v0.4.1 lunny/gitea
4 participants
@lunny @gsvd @aceArt-GmbH @kemzeb