Skip to content

External Issue Identifier With Trailing Comma Doesn't Get Linked #32428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
friedrichsenm opened this issue Nov 5, 2024 · 0 comments · Fixed by #32945
Closed

External Issue Identifier With Trailing Comma Doesn't Get Linked #32428

friedrichsenm opened this issue Nov 5, 2024 · 0 comments · Fixed by #32945
Labels
type/bug

Comments

@friedrichsenm
Copy link

friedrichsenm commented Nov 5, 2024 •
edited
Loading

Description

If you have a repo configured to use an external issue tracker and use the alphanumeric issue identifier, then valid issues with a trailing comma won't get dynamically linked in a PR title. For example:
TAG-1234 <PR title text> works
TAG-1234: <PR title text> works
TAG-1234, <PR title text> does NOT work

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

Yes

Example PR with working issue link:
https://gitea.com/friedrichsenm/test_issue_linking/pulls/1

Example PR with missing issue link:
https://gitea.com/friedrichsenm/test_issue_linking/pulls/2

Log Gist

No response

Screenshots

Can't reproduce in demo right now since the site is down

Git Version

No response

Operating System

Ubuntu

How are you running Gitea?

rootless docker image

Database

PostgreSQL
@katsusan katsusan mentioned this issue Dec 22, 2024
Merged
@lunny lunny closed this as completed in fb75151 Dec 22, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 22, 2024
@katsusan @GiteaBot
fix trailing comma not matched in the case of alphanumeric issue (go-…
3f77f4f 
…gitea#32945)

Fix go-gitea#32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.
@GiteaBot GiteaBot mentioned this issue Dec 22, 2024
Merged
lunny pushed a commit that referenced this issue Dec 22, 2024
@GiteaBot @katsusan
fix trailing comma not matched in the case of alphanumeric issue (#32945
a8f98fd 
) (#32959)

Backport #32945 by @katsusan

Fix #32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.

Co-authored-by: katsu <evergonuaa@gmail.com>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@katsusan
fix trailing comma not matched in the case of alphanumeric issue (go-…
4999de5 
…gitea#32945)

Fix go-gitea#32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.

(cherry picked from commit fb75151)
(cherry picked from commit 0efd713)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix trailing comma not matched in the case of alphanumeric issue katsusan/gitea
1 participant
@friedrichsenm