Skip to content

Repository expolore pagination problem #31807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hametan opened this issue Aug 9, 2024 · 3 comments · Fixed by #31832
Closed

Repository expolore pagination problem #31807

hametan opened this issue Aug 9, 2024 · 3 comments · Fixed by #31832
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.22.2

Comments

@hametan
Copy link

hametan commented Aug 9, 2024

Description

设置了过滤条件，如：非镜像，翻页未带上过滤参数。

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

打开 https://demo.gitea.com/explore/repos 点击过滤 ，点击非镜像，点第二页。

Database

PostgreSQL
@lunny
Copy link
Member

lunny commented Aug 9, 2024

I don't it's a bug. When filters changed, you should visit from page 1 again.

@lunny lunny added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed type/bug labels Aug 9, 2024
@lunny lunny changed the title 项目列表过滤翻页BUG Repository expolore pagination problem Aug 9, 2024
@yp05327
Copy link
Contributor

yp05327 commented Aug 15, 2024 •
edited
Loading

I don't it's a bug. When filters changed, you should visit from page 1 again.

No. I can confirm this issue.
First, visit the first page, and change the filter to No mirrored.
Then click page 2, the No mirrored filter is missing.

@yp05327 yp05327 added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea labels Aug 15, 2024
@yp05327
Copy link
Contributor

yp05327 commented Aug 15, 2024

#29231 forgot add these newly added params to pager

@yp05327 yp05327 mentioned this issue Aug 15, 2024
Merged
@lunny lunny added this to the 1.22.2 milestone Aug 15, 2024
lunny pushed a commit that referenced this issue Aug 15, 2024
@yp05327
Add missing repository type filter parameters to pager (#31832)
7092402 
Fix #31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Aug 15, 2024
@yp05327 @GiteaBot
Add missing repository type filter parameters to pager (go-gitea#31832)
cbe44ff 
Fix go-gitea#31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?
@GiteaBot GiteaBot mentioned this issue Aug 15, 2024
Merged
wolfogre pushed a commit that referenced this issue Aug 16, 2024
@GiteaBot @yp05327
Add missing repository type filter parameters to pager (#31832) (#31837)
771fb45 
Backport #31832 by @yp05327

Fix #31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?

Co-authored-by: yp05327 <576951401@qq.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 13, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@yp05327 @earl-warren
Add missing repository type filter parameters to pager (go-gitea#31832)
c5acd41 
Fix go-gitea#31807

ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?

(cherry picked from commit 7092402)

Conflicts:
	routers/web/org/home.go
  trivial conflict s/pager.AddParam/pager.AddParamString/
(cherry picked from commit a8e25e9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.22.2
Development

Successfully merging a pull request may close this issue.

Add missing repository type filter parameters to pager yp05327/gitea
3 participants
@lunny @hametan @yp05327