Second Issue Dependency Private #27357
Labels
Comments
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Jan 12, 2024
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
lafriks
pushed a commit
that referenced
this issue
Jan 12, 2024
Backport #27736 by @lng2020 Fix #27722 Fix #27357 Fix #25837 Fix #28732 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too.  Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this issue
Jan 17, 2024
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
silverwind
pushed a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this issue
Jan 23, 2025
Backport go-gitea#27736 by @lng2020 Fix go-gitea#27722 Fix go-gitea#27357 Fix go-gitea#25837 Fix go-gitea#28732 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too.  Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com> (cherry picked from commit 571822b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
For some reason, the second issue in issue dependencies is labeled "hidden" (even when they have the same settings). To recreate:
Gitea Version
current main & 1.20
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
try.gitea
Database
None
The text was updated successfully, but these errors were encountered: