Skip to content

git client cluttered since update of container #24951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yogo1212 opened this issue May 26, 2023 · 5 comments · Fixed by #24952
Closed

git client cluttered since update of container #24951

yogo1212 opened this issue May 26, 2023 · 5 comments · Fixed by #24952
Assignees
@wxiaoguang
Labels
type/bug
Milestone
1.20.0

Comments

@yogo1212
Copy link
Contributor

yogo1212 commented May 26, 2023 •
edited
Loading

Description

After a recent update, all ssh interactions with the server produces loads of lines like these:

$ git push origin :qwer
2023/05/26 21:54:52 start process 64712aac: LoggerManager (system)
remote: 2023/05/26 21:54:52 start process 64712aac: LoggerManager (system)
remote: 2023/05/26 21:54:53 start process 64712aad: LoggerManager (system)
remote: 2023/05/26 21:54:53 start process 64712aad: LoggerManager (system)

Gitea Version

1.20.0+dev-923-gabccb86b3

How are you running Gitea?

Podman image nightly-rootless (29f8336a623e)

Database

PostgreSQL
@wxiaoguang
Copy link
Contributor

Related to #24924 , will do more clean up

@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 27, 2023
@wxiaoguang wxiaoguang self-assigned this May 27, 2023
@wxiaoguang wxiaoguang mentioned this issue May 27, 2023
Merged
@wxiaoguang
Copy link
Contributor

-> Do not output "Trace" level logs from process manager by default #24952

@yogo1212
Copy link
Contributor Author

Thanks for your work! 😊

silverwind pushed a commit that referenced this issue May 27, 2023
@wxiaoguang
Do not output "Trace" level logs from process manager by default (#24952
7314726 
)

The old process manager's `Trace` function by default calls `log.Printf`
to output "trace" level logs. That's not ideal because by default the
trace level logs should not be outputted. In history it didn't cause
problems because there was no other call to the process manager before
the logger system's initialization.

But if there is any package using the process manager before the "Trace"
function gets assigned to the logger system's trace function, the
process manager will outputs unexpected verbose messages, this behavior
is not expected in most cases.

Now, the logger system also uses process manager to manage its goroutine
contexts, so it's the time to fix the old "trace" behavior: by default,
do not output the trace level messages. Fix #24951
@wxiaoguang
Copy link
Contributor

#24952 has been merged and the nightly build has been released. Please try the latest nightly. Sorry for the inconvenience

@yogo1212
Copy link
Contributor Author

yogo1212 commented Jun 1, 2023

@wxiaoguang no inconvenience!
granted, my using nightly isn't entirely voluntary but finding bugs early is what nightly is about.
thanks for your work on gitea ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wxiaoguang wxiaoguang

Labels
type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Do not output "Trace" level logs from process manager by default wxiaoguang/gitea
2 participants
@wxiaoguang @yogo1212