Skip to content

Lowercase headers #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Lowercase headers #533

merged 4 commits into from
Dec 16, 2024

Conversation

arashnd
Copy link
Contributor

@arashnd arashnd commented Oct 30, 2024

All PRs:

  • Has tests
  • Documentation updated

Adding a new header

Generally, adding a new header is always OK.

  • Is the header supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the header?
  • Where does the specification live?

Adding a new CSP directive

  • Is the directive supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the directive?

Rack 3 Response header keys can no longer include uppercase characters.
https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rack-3-upgrade-guide

Rack Lint error out when using secure_headers because its adding headers with uppercase

Rack::Lint::LintError: uppercase character in header name: X-Frame-Options (Rack::Lint::LintError)

@obrie
Copy link

obrie commented Nov 22, 2024

Thanks for working on this! It'd be great to have this merged and released to unblock local development with Rack 3.x.

Copy link
Contributor

@rzhade3 rzhade3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! This is a great change. Couple changes suggested below after which we can merge this PR in:

@arashnd
Copy link
Contributor Author

arashnd commented Dec 6, 2024

thanks! @rzhade3

@rzhade3 rzhade3 requested a review from KyFaSt December 6, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants