server: Fix the status of finish_reason if the stream value is False #10382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeongBeomLEE
changed the title
ngxson
requested changes
Nov 18, 2024
There was a problem hiding this comment.
I temporary revoke my approval because the CI failed.
It's likely due to another bug in the code, unrelated to this PR. In anyway, the 3 bool stopped_eos, stopped_word, stopped_limit are too hacky and they should be refactored into one single enum.
I would appreciate if you (or someone) can take time to refactor this whole stopped_* mechanism.
|
can you merge the current PR to resolve the issue? I will leave another PR later on what you talked about. thanks. |
|
I'm closing this because I moved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"finish_reason" returns "stop" in all cases because the "stop_word" value is always "True" when using "stream false mode" in /chat/completions API.
So modify the "stopped_word" value so that "length" can also be returned.
Thanks.