fix(cloudflare): Capture exceptions thrown in hono #16355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
changed the title
AbhiPrasad
approved these changes
May 21, 2025
| if ( | ||
| 'onError' in handler && | ||
| 'errorHandler' in handler && | ||
| typeof handler.errorHandler === 'function' && |
There was a problem hiding this comment.
So this is always defined right? We don't need to create one for a user if it's not defined?
There was a problem hiding this comment.
yes, hono has a default error handler: https://github.com/honojs/hono/blob/bb7afaccfd5b6b514da356e069f27eb5ccfc0e3b/src/hono-base.ts#L36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cloudflare SDK captures fetch exceptions in the catch block. But hono never reaches this block where we send exceptions.
hono processes errors with their
onErrorfunction (orerrorHandler) and we need to capture the exception there.This PR wraps the
errorHandlerof hono.Will create an E2E test in another PR.