Skip to content

ref: Turn default exports into named exports #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 19, 2023

Fixes #161

Turns all the default exports of the plugins into named exports. This is just way more future proof in case we want to export more stuff and properly support CJS at the same time.

@lforst lforst marked this pull request as ready for review January 19, 2023 10:08
@lforst lforst requested a review from Lms24 January 19, 2023 10:08
@lforst lforst self-assigned this Jan 19, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a breaking change, right?

Then let's add an entry to MIGRATION.md. Also, we'll need to update docs

@lforst lforst enabled auto-merge (squash) January 19, 2023 10:22
@lforst lforst disabled auto-merge January 19, 2023 10:22
@lforst lforst enabled auto-merge (squash) January 19, 2023 10:38
@lforst lforst merged commit f783689 into main Jan 19, 2023
@lforst lforst deleted the lforst-named-exports branch January 19, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentryEsbuildPlugin is not a function
2 participants