Skip to content

ref(core): Decouple breadcrumb usage from logger #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2022
Merged

ref(core): Decouple breadcrumb usage from logger #138

merged 3 commits into from
Nov 28, 2022

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Nov 28, 2022

Breadcrumbs can potentially leak PII so we make their usage explicit.

@lforst lforst requested review from mydea, Lms24 and AbhiPrasad November 28, 2022 10:13
@lforst lforst self-assigned this Nov 28, 2022
@lforst lforst enabled auto-merge (squash) November 28, 2022 10:35
@lforst lforst merged commit dd83bc3 into main Nov 28, 2022
@lforst lforst deleted the lforst-decouple-breadcrumb-usage-from-logger branch November 28, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @mydea @AbhiPrasad