Skip to content

Introduce file versioning #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 6, 2025
Merged

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Apr 25, 2025

Description

Porting jupytercad/JupyterCAD#623

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--663.org.readthedocs.build/en/663/
💡 JupyterLite preview: https://jupytergis--663.org.readthedocs.build/en/663/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/schema-version

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Integration tests report: appsharing.space

@martinRenou martinRenou added the enhancement New feature or request label Apr 25, 2025
@mfisher87
Copy link
Member

As we introduce file versioning, should we also create a new constant COMPATIBILITY_BOUNDS or something, so that we can recognize when we open an incompatible document and let the user know?

@arjxn-py
Copy link
Member Author

arjxn-py commented Apr 30, 2025

I wonder why the integration tests are still failing
again, it works fine on lite deployment -
image

@arjxn-py arjxn-py marked this pull request as ready for review April 30, 2025 09:26
@arjxn-py arjxn-py requested a review from martinRenou April 30, 2025 09:52
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 93689d8 into geojupyter:main May 6, 2025
14 checks passed
@mfisher87
Copy link
Member

@arjxn-py @martinRenou What do you think, should schema_version be under metadata? I had originally assumed this would be the case.

@martinRenou
Copy link
Member

That would make sense to me 👍🏽

@mfisher87
Copy link
Member

Follow-up: We discussed in our stand-up on Tuesday and decided that since the .ipynb format has version info at the root, we'll follow that pattern.

@mfisher87 mfisher87 linked an issue May 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include schema version in JGIS project files
3 participants