-
Notifications
You must be signed in to change notification settings - Fork 459
goseq: update to 1.44.0 #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goseq: update to 1.44.0 #3331
Conversation
Remove short flags due to r-optparse update giving this error Error in make_option(c("-lf", "--length_file"), type = "character", default = NULL, : Short flag -lf must only be a '-' and a single letter and short flags not necessary Update test output, seems zebrafish output changed
Have fixed the linting issues here except 2, Other R tools here have similiar issue e.g deseq2 I wonder if the lintr here is too strict as this issue was reported here Seems because (as says here r-lib/lintr#382)
Workaround in first issue
e.g. Is that what needs to be done or something else? |
@mblue9 can you use If you think this is more problematic than useful we need to discuss the linting step of R code again. |
I'll have a look, will be good to use the linting if possible. By the way these R jobs are also failing here due to timeouts during the planemo testing, taking > 6hrs |
@mblue9 please try to add r-base as dependency. r-base=4.0 should hopefully work. |
@mblue9 fixed! The failing tests now are real: We also included linting of R code, do you have time to fix that? We also included xref and EDAM tags. It would be nice if those could be added too: https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-xrefs-xref You can find that information here: https://bio.tools/goseq Thanks! |
Gracias! :) |
FOR CONTRIBUTOR: