-
Notifications
You must be signed in to change notification settings - Fork 187
Changes directory structure of stdlib as discussed in #216 #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The FORD documentation can be dowloaded here. |
This is a major change in terms of structure for |
I think we are ok with the general idea to do it like this. I think the only thing to figure out is how exactly to document that all those routines are experimental. Should we also add a comment next to each subroutine in the source file? I think I would prefer that --- we want to convey as clearly as possible that the subroutine is experimental. |
@certik I believe having the version: experimental as @jvdp1 has done should suffice. Having the experimental tag in the Ford doc comments covers all bases. Is there anywhere else that would more clearly indicate the experimental nature of a function? Could we have a script that simply parses out "version: experimental" and lists them in the docs? Maybe this is something we could add to FORD? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you @jvdp1.
I can't review all 51 files, but I trust that it's all or mostly correct. If there are any issues we can fix them as we go.
IMO it's clear enough that procedures are experimental the way it's documented now, but if others want it more explicitly documented, I don't object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the current way the version is done, as long as nobody objects. I am always more cautious with regards to these things.
I've been away for a while. I am ok with the change in structure. |
The version of each procedure is mentioned in FORD website when you open the page of a procedure. |
So in the generated docs, experimental interfaces get a subsection like VersionExperimental What would this say for stable interfaces, "stable"? Seems strange to me. Might just be the word "version". If we are only classifying interfaces as "experimental" or "stable", I think maybe calling this section "status" makes more sense? If I'm a user and I see "Version: stable", I wonder "OK, so is there and unstable version as well?" (a la how some Linux distributions classify packages as stable/unstable/testing). Other than that detail, I support this change. |
I agree, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the suggested change version
->status
. Otherwise good to go, thanx @jvdp1 !
I agree with the comments on IMO The StatusStable, since x.x.x |
Yes this is a good and necessary change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. When we get to the point of actually stabilizing a routine we should edit the WORKFLOW.md with more accurate instructions on how the status is upgraded.
+1 to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge.
It seems there is an agreement on the proposed change of the structure of |
This PR changes the directory structure of stdlib as discussed in #216 opened by @wclodius2
In short: