-
Notifications
You must be signed in to change notification settings - Fork 15
Override TERMINFO_DIRS to prefer host terminfo files over builtin ones #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Started test build 59167 |
Build 59167 successful
|
Started test build 63648 |
Build 63648 successful
|
Would this also be required for host's |
I think it is used by default by ncurses if it exists but im not sure if the |
I have confirmed that I have placed same terminfo file in
EDIT: GH automatically closed the PR, my bad |
Started test build 64276 |
Build 64276 successful
|
Started test build 64278 |
Build 64278 successful
|
Started test build 77564 |
Build 77564 successful
|
Queued test build for io.neovim.nvim. |
Started test build 143145 |
Queued test build for io.neovim.nvim. |
bot, build |
Queued test build for io.neovim.nvim. |
Started test build 143146 |
Build 143145 successful
|
Build 143146 successful
|
@@ -14,6 +14,7 @@ finish-args: | |||
- --filesystem=host | |||
- --filesystem=/tmp | |||
- --filesystem=/var/tmp | |||
- --env=TERMINFO_DIRS='/var/run/host/usr/share/terminfo:/usr/share/terminfo' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't '--env=TERMINFO_DIRS=/app/share/terminfo:'
enough to work? Could you try and let me know, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make using terminals like kitty, wezterm, etc that use custom terminfo painless and possibly prevent issues with mismatch of terminfo versions as the terminfo that comes with the terminal is used