Skip to content

Override TERMINFO_DIRS to prefer host terminfo files over builtin ones #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sandorex
Copy link

This would make using terminals like kitty, wezterm, etc that use custom terminfo painless and possibly prevent issues with mismatch of terminfo versions as the terminfo that comes with the terminal is used

@flathubbot
Copy link
Contributor

Started test build 59167

@flathubbot
Copy link
Contributor

Build 59167 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41802/io.neovim.nvim.flatpakref

@flathubbot
Copy link
Contributor

Started test build 63648

@flathubbot
Copy link
Contributor

Build 63648 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46286/io.neovim.nvim.flatpakref

@christianparpart
Copy link

christianparpart commented Sep 6, 2023

Would this also be required for host's ~/.terminfo as well? If so, I'd highly suggest to also provide a mapping for this. :)

@sandorex
Copy link
Author

sandorex commented Sep 6, 2023

Would this also be required for host's ~/.terminfo as well? If so, I'd highly suggest to also provide a mapping for this. :)

I think it is used by default by ncurses if it exists but im not sure if the TERMINFO_DIRS modifies the priority, ill have to check

@sandorex
Copy link
Author

sandorex commented Sep 8, 2023

I have confirmed that ~/.terminfo is preferred by default so there is no need to add it

I have placed same terminfo file in ~/.terminfo and added env TERMINFO_DIRS=/var/run/host/usr/share/terminfo/:/usr/share/terminfo and it still takes it from ~/.terminfo, as always this depends on the application following the convention

[📦 io.neovim.nvim ~]$ infocmp -l
#	Reconstructed via infocmp from file: /home/sandorex/.terminfo/x/xterm-kitty
...

EDIT: GH automatically closed the PR, my bad

@flathubbot
Copy link
Contributor

Started test build 64276

@sandorex sandorex reopened this Sep 8, 2023
@flathubbot
Copy link
Contributor

Build 64276 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46911/io.neovim.nvim.flatpakref

@flathubbot
Copy link
Contributor

Started test build 64278

@flathubbot
Copy link
Contributor

Build 64278 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46913/io.neovim.nvim.flatpakref

@flathubbot
Copy link
Contributor

Started test build 77564

@flathubbot
Copy link
Contributor

Build 77564 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/60157/io.neovim.nvim.flatpakref

@flathubbot
Copy link
Contributor

Queued test build for io.neovim.nvim.

@flathubbot
Copy link
Contributor

Started test build 143145

@flathubbot
Copy link
Contributor

Queued test build for io.neovim.nvim.

@CleoMenezesJr
Copy link
Collaborator

bot, build

@flathubbot
Copy link
Contributor

Queued test build for io.neovim.nvim.

@flathubbot
Copy link
Contributor

Started test build 143146

@flathubbot
Copy link
Contributor

Build 143145 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126199/io.neovim.nvim.flatpakref

@flathubbot
Copy link
Contributor

Build 143146 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126200/io.neovim.nvim.flatpakref

@@ -14,6 +14,7 @@ finish-args:
- --filesystem=host
- --filesystem=/tmp
- --filesystem=/var/tmp
- --env=TERMINFO_DIRS='/var/run/host/usr/share/terminfo:/usr/share/terminfo'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't '--env=TERMINFO_DIRS=/app/share/terminfo:' enough to work? Could you try and let me know, please?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants