Skip to content

Add class for SAML provider config. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 18, 2020
Merged

Add class for SAML provider config. #419

merged 5 commits into from
May 18, 2020

Conversation

micahstairs
Copy link
Contributor

Adds a class for the SAML provider config.

hiranya911
hiranya911 suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just need to remove some of the nested types from the public API surface.

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 18, 2020
hiranya911
hiranya911 suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the compilation failure.

@micahstairs micahstairs changed the base branch from micahstairs-provider-cleanup to idp-config May 18, 2020 19:09
hiranya911
hiranya911 suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that we can deserialize the response into an instance of SamlProviderConfigResponse, and then realized we can't really do that. I've proposed a couple of options to clean things up a bit. Let me know how you feel about them.

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 18, 2020
hiranya911
hiranya911 approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 18, 2020
@micahstairs micahstairs merged commit 51fdc91 into idp-config May 18, 2020
micahstairs added a commit that referenced this pull request Jun 12, 2020
@micahstairs
Add class for SAML provider config. (#419)
537b7a7 
Adds a class for the SAML provider config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees

@lahirumaramba lahirumaramba

@micahstairs micahstairs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micahstairs @hiranya911 @lahirumaramba