Add operations to create and delete OIDC provider configs. #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahstairs
commented
Apr 28, 2020
src/main/java/com/google/firebase/auth/FirebaseUserManager.java
Outdated
Show resolved
Hide resolved
hiranya911
suggested changes
Apr 28, 2020
src/main/java/com/google/firebase/auth/FirebaseUserManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/auth/FirebaseUserManager.java
Outdated
Show resolved
Hide resolved
hiranya911
reviewed
Apr 28, 2020
micahstairs
changed the base branch from
micahstairs-oidc-changes
to
idp-config
|
I've merged the other PR into this and changed the base branch to idp-config. |
hiranya911
suggested changes
Apr 29, 2020
src/main/java/com/google/firebase/auth/FirebaseUserManager.java
Outdated
Show resolved
Hide resolved
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
This adds an operation to create OIDC provider configs, as well as an operation to delete provider configs. These operations can be performed using either the tenant-aware or standard Firebase client. This work is part of adding multi-tenancy support (see issue #332).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an operation to create OIDC provider configs (can be done using either the tenant-aware or standard Firebase client), as well as an operation to delete provider configs.
I spent some time trying to see if we could make the create operation generic so that it could support both OIDC and SAML provider configs, however, I'm concerned that such a solution would add complexity to the external API, rather than making it simpler. I think it would also introduce some sort of
instanceofcheck internally.This work is part of adding multi-tenancy support (see issue #332).