Fix variable type from method return value, add tests #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens1o
approved these changes
Jun 10, 2017
felixfbecker
approved these changes
Jun 10, 2017
felixfbecker
changed the title
lialan
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in DefinitionResolver correctly resolves the type of a method call expression.
Includes completion tests for a method and a static function. Also adds validation tests to check that the definitions of these methods are handled correctly (although this was correct before). I also modified the validation test to write the tostring value of the definition type, instead of just the class. This is much more useful.
Fixes #386