Remove formatting

[felixfbecker]

At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases (while editing), overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

cc @roblourens @mniewrzal @kaloyan-raev

[kaloyan-raev]

I agree. The CodeSniffer formatting looked like a good idea in the early days of the PHP LS. But if it causes so much trouble, it is better to look for an alternative.

[felixfbecker]

To be clear, I am proposing to remove it even without having an alternative

[roblourens]

I agree that tolerant-php-parser needs to support this, but in the meantime, is there no other alternative for PHP pretty printing?

[felixfbecker]

also cc @damieng

[damieng]

No change needed in the Atom package - although we register the ability to code format in the package.json it still degrades functionality dynamically based on the initializationResponse.