Skip to content

💡 Remove unnecessary comment #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

sebhani
Copy link
Contributor

@sebhani sebhani commented Jul 21, 2024

engine is created using create_engine function in the same file (i.e., db.py). Therefore, uncommenting from app.core.engine import engine line is unnecessary and would result in ModuleNotFoundError: No module named 'app.core.engine' error.

engine is created using create_engine function in the same file (i.e., db.py)
@tiangolo tiangolo changed the title Fix disabling Alembic 💡 Remove unnecessary comment Sep 27, 2024
@tiangolo
Copy link
Member

Cool, thanks!

@tiangolo tiangolo merged commit 08dd87d into fastapi:master Sep 27, 2024
10 checks passed
JBLangton pushed a commit to JBLangton/full-stack-fastapi-template that referenced this pull request Mar 29, 2025
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants