-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Apply useESModules option to @babel/preset-env #5973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for create-react-app ready! Built with commit aaf7186627e68ed33353d8c51c94985941277216 |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Are there any chances this PR would be merged to master any soon? Or could someone elaborate what's other way of using react-app preset in node environment with transforming modules (except forking it)? |
@sebryu For now u can use "@babel/plugin-transform-modules-commonjs" plugin. {
"presets": [["react-app", { "useESModules": false }]],
"plugins": [["@babel/plugin-transform-modules-commonjs", { "loose": true }]]
} |
@strayiker Thanks a lot! This config worked for me, but it would be still useful to have that configurable in react-app preset |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
Related to this comment