Skip to content

Apply useESModules option to @babel/preset-env #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

strayiker
Copy link

@netlify
Copy link

netlify bot commented Dec 6, 2018

Deploy preview for create-react-app ready!

Built with commit aaf7186627e68ed33353d8c51c94985941277216

https://deploy-preview-5973--create-react-app.netlify.com

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 6, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 6, 2019
@sebryu
Copy link

sebryu commented Jan 7, 2019

Are there any chances this PR would be merged to master any soon? Or could someone elaborate what's other way of using react-app preset in node environment with transforming modules (except forking it)?

@stale stale bot removed the stale label Jan 7, 2019
@strayiker
Copy link
Author

@sebryu For now u can use "@babel/plugin-transform-modules-commonjs" plugin.

{
  "presets": [["react-app", { "useESModules": false }]],
  "plugins": [["@babel/plugin-transform-modules-commonjs", { "loose": true }]]
}

@sebryu
Copy link

sebryu commented Jan 16, 2019

@strayiker Thanks a lot! This config worked for me, but it would be still useful to have that configurable in react-app preset

@stale
Copy link

stale bot commented Feb 15, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 15, 2019
@stale
Copy link

stale bot commented Feb 20, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Feb 20, 2019
@lock lock bot locked and limited conversation to collaborators Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants