Skip to content

add shebang to tasks scripts #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2016
Merged

Conversation

apaleslimghost
Copy link
Contributor

tasks/e2e.sh and tasks/release.sh expect to be run with Bash (function etc) but fail in Dash (default Ubuntu /bin/sh) or Zsh (my default shell). Add shebangs so they run with the right shell.

@ghost ghost added the CLA Signed label Aug 5, 2016
@vjeux
Copy link
Contributor

vjeux commented Aug 5, 2016

Thanks!

@vjeux vjeux merged commit 6fb517a into facebook:master Aug 5, 2016
@ghost ghost added the CLA Signed label Aug 5, 2016
gaearon pushed a commit that referenced this pull request Aug 22, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants