rna-transcription: Remove as_ref test #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in 7877d63 back when the exercises was ported to xrust, but there's no clear reason why we would want the RNA to be convertible to a string. * It's not relevant to the problem statement. * There's no clear use case for why this is something that should be required. * Other languages don't do this. * Other exercises in xrust don't do this. Given these reasons, it makes more sense to remove it. Closes #76
|
Sounds fair. Thanks! |
EduardoBautista
added a commit
that referenced
this pull request
Mar 8, 2016
rna-transcription: Remove as_ref test
This was referenced Apr 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in 7877d63 back
when the exercises was ported to xrust, but there's no clear reason why
we would want the RNA to be convertible to a string.
required.
Given these reasons, it makes more sense to remove it.
Closes #76