beer-song: replace with bottle-song #2021
Conversation
|
Let's do the deprecation of the old exercise together with the implementation of the new one. |
ellnix
force-pushed
the
beer-song-deprecation
branch
from
ce621ba to
fc4dac2
Compare
| @@ -9,7 +9,12 @@ use bottle_song::*; | |||
| fn {{ test.description | make_ident }}() { | |||
| assert_eq!( | |||
| recite({{ test.input.startBottles }}, {{ test.input.takeDown }}), | |||
There was a problem hiding this comment.
I saw that beer-song called trim() on this value, but that just feels like cheating...
It's up to the student to use trim() if they need it, in my opinion.
|
Thought |
| recite({{ test.input.startBottles }}, {{ test.input.takeDown }}), | ||
| concat!( | ||
| {% for line in test.expected %} | ||
| "{{line}}{% if not loop.last %}\n{% endif %}", |
There was a problem hiding this comment.
nit: keep the trailing newline
There was a problem hiding this comment.
I went through other repos after receiving this feedback, I had only looked at Elixir which does not have the newline. Ruby seems to have the newline, and python, javascript, and go seem to return some sort of array of strings.
Should we just go for a Vec of Strings?
I'll keep the trailing new line in the meantime, even though I think that the challenge makes more sense without it. But it's no big deal.
There was a problem hiding this comment.
Should we just go for a Vec of Strings?
Nah, that seems weird to me.
In my mind, text that consists of multiple lines should always have a trailing newline. But it's not important. Neither alternatives result in a more or less interesting / challenging exercise.
Maybe that's what the trim call was for. Allow students to implement their preference, with or without trailing newline.
There was a problem hiding this comment.
I can add trim if you want, or else I guess we can merge this as is?
There was a problem hiding this comment.
Added trim(), feel free to merge if you have no reservations.
Now in line with old beer-song exercise.
No description provided.