trie: add edgecase for rangeproof correctness #31667
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if bytes.Compare(keys[i], keys[i+1]) >= 0 { | ||
| return false, errors.New("range is not monotonically increasing") | ||
| } | ||
| if bytes.HasPrefix(keys[i+1], keys[i]) { |
There was a problem hiding this comment.
In the case of ethereum, the key length is always 32.
e.g. in func (s *Syncer) OnAccount or func (s *Syncer) OnStorage
so it's not risky.
I have to think about if it makes sense to ensure the length of keys are all same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checking for an edgecase which theoretically can happen in the range-prover. Right now, we check that a key does not overwrite a previous one by checking that the key is increasing. However, if keys are of different lengths, it is possible to create a key which is increasing and overwrites the previous key. Example:
0xaabbccfollowed by0xaabbccdd.This can not happen in go-ethereum, which always uses fixed-size paths for accounts and storage slot paths in the trie, but it might happen if the range prover is used without guaranteed fixed-size keys.
This PR also adds some testcases for the errors that are expected.