eth/gasprice: multipled by the oracle.percentile for element in gasprice results slice
#31627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the percentile for price result in slice
|
Why is this considered incorrect? In the original implementation, we sampled recent blocks, collected the gas price of each individual transaction, and returned a specific value based on the desired percentile. e.g., if we sample the recent 3 blocks, each of them have 3 txs, |
|
I think the original approach is correct, so I’ll go ahead and close this for now. Feel free to reopen it if you think there’s a need for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the percentile for price result in slice