Skip to content

core/rawdb: integrate eradb backend for RPC #31604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 10, 2025

Implements #31279

@fjl fjl added this to the 1.15.9 milestone Apr 15, 2025
@rjl493456442 rjl493456442 self-assigned this Apr 15, 2025
@s1na s1na marked this pull request as ready for review April 17, 2025 08:28
@s1na s1na changed the title WIP: integrate eradb backend for RPC core/rawdb: integrate eradb backend for RPC Apr 17, 2025
@@ -237,7 +237,7 @@ func initGenesis(ctx *cli.Context) error {
overrides.OverrideVerkle = &v
}

chaindb, err := stack.OpenDatabaseWithFreezer("chaindata", 0, 0, ctx.String(utils.AncientFlag.Name), "", false)
chaindb, err := stack.OpenDatabaseWithFreezer("chaindata", 0, 0, ctx.String(utils.AncientFlag.Name), "", false, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make this a config struct

@rjl493456442
Copy link
Member

Twist the era path resolution a bit:

  • use ancient/chain/era if era is not explicitly specified;
  • use ancient/chain/relative-path if era is specified;
  • use itself if the specified path is an absolute path

return f.eradb.GetRawReceipts(number)
}
return nil, errUnknownTable
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO (sina and gary)

We should support AncientRange as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a ticket for it for a future PR

@MariusVanDerWijden MariusVanDerWijden modified the milestones: 1.15.9, 1.15.10 Apr 23, 2025
@fjl fjl modified the milestones: 1.15.10, 1.15.11 Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants