-
Notifications
You must be signed in to change notification settings - Fork 312
Add 3.6 downgrade instructions. #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ffc44bc
to
79f6639
Compare
Thanks for the PR, @siyuanfoundation. The v3.6 update guide link isn't working. I opened #966 to add a layout/placeholder so we can avoid these issues. Could you please take a look at the linter issues? https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/965/pull-website-lint/1895572262531108864 Thanks again :) |
79f6639
to
159d5a9
Compare
Could you move the downgrade_3.5 related change into a separate PR? It should can be approved & merged soon. @fuweid can you please take a look at the downgrade_3.6 guide if you get time? thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just have few minior questions.
Thanks!
|
||
```diff | ||
-etcd-old --name s1 \ | ||
+etcd-new --name s1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about etcd-3.4-bin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
|
||
```diff | ||
-etcd-old --name s1 \ | ||
+etcd-new --name s1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about etcd-3.5-bin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
+-----------------+------------------+---------------+-----------------+---------+--------+-----------------------+-------+-----------+------------+-----------+------------+--------------------+--------+--------------------------+-------------------+ | ||
| ENDPOINT | ID | VERSION | STORAGE VERSION | DB SIZE | IN USE | PERCENTAGE NOT IN USE | QUOTA | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS | DOWNGRADE TARGET VERSION | DOWNGRADE ENABLED | | ||
+-----------------+------------------+---------------+-----------------+---------+--------+-----------------------+-------+-----------+------------+-----------+------------+--------------------+--------+--------------------------+-------------------+ | ||
| localhost:2379 | 8211f1d0f64f3269 | 3.5.18 | | 20 kB | 16 kB | 20% | 0 B | false | false | 3 | 14 | 14 | | | false | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first row with disabled maybe confusing because the DowngradeInfo isn't backported to v3.5.
I was thinking that we should highlight this information to user: it's still enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a Note.
3.5 changes in #970 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the page.
The CI fails because of lack of index.html
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fuweid, siyuanfoundation The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @ajaysundark for the careful review! |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Once the downgrade has been enabled, the cluster version and storage version will be downgraded to 3.5, and operations and storage will be "3.5" compatible. You would need to follow the [Upgrade etcd from 3.5 to 3.6](../../upgrades/upgrade_3_6/) instructions to rollback. | ||
|
||
Please [download the snapshot backup](../../op-guide/maintenance/#snapshot-backup) to make downgrading the cluster possible even after it has been completely downgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not understand this. Do you mean "to make rollback the cluster possible ..."? It seems duplicated to the section "Preparation".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. Removed.
```bash | ||
etcdctl downgrade validate 3.5 | ||
<<COMMENT | ||
Downgrade validate success, cluster version 3.6 | ||
COMMENT | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add description/clarification something like below,
- We only support one minor version at a time. e.g downgrading from 3.6 to 3.4 isn't allowed.
- Please do not move on to next step until the validation is successful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
COMMENT | ||
``` | ||
|
||
If the server to be stopped is the leader, you can avoid some downtime by `move-leader` to another server before stopping this server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can recommend users to downgrade the leader last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
e09eb5c
to
cf6c555
Compare
Signed-off-by: Siyuan Zhang <sizhang@google.com> Co-authored-by: ajaysundar.k <ajaysundar.k@gmail.com>
#960