Skip to content

Feature/fstring updates #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

Back2Basics
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use refs #... in the description of the pull request.

all tests pass
more f strings done
f string modifications
blah blah
Less f strings needed for non-modified strings and one indentation speedup fixed.
@Back2Basics Back2Basics changed the title Feature/fstringupdates Feature/fstring updates Feb 20, 2022
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! Looking good.
Left a few review comments on this.

Back2Basics and others added 4 commits February 28, 2022 20:50
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
found more with another pattern
Back2Basics and others added 2 commits March 3, 2022 23:31
Co-authored-by: Tom Christie <tom@tomchristie.com>
@Back2Basics
Copy link
Contributor Author

I believe I've gotten all the questions addressed with the latest update (as of Mar 19, 2022). As always I value your feedback.

@wieczorek1990
Copy link
Contributor

Please reword or rebase the commits.

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2022
@stale stale bot closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants