Binaryen stack branch support #4528
Conversation
| if shared.Settings.BINARYEN_IMPRECISE: | ||
| cmd += ['--imprecise'] | ||
| if opt_level == 0: | ||
| cmd += ['--no-opts'] | ||
| # import mem init file if it exists, and if we will not be using asm.js as a binaryen method (as it needs the mem init file, of course) | ||
| import_mem_init = memory_init_file and 'asmjs' not in shared.Settings.BINARYEN_METHOD and 'interpret-asm2wasm' not in shared.Settings.BINARYEN_METHOD | ||
| if import_mem_init and os.path.exists(memfile): |
There was a problem hiding this comment.
Just checking, is the semantic of import_mem_init at this point intended to be import_mem_init_if_it_exists or import_mem_init_and_it_should_exist? This line feels odd since above we unconditionally did set memory_init_file = True?
kripken
force-pushed
the
binaryen-stack
branch
from
a7fd483 to
16b6e35
Compare
…we use wasm globals
kripken
force-pushed
the
binaryen-stack
branch
from
16b6e35 to
5c46091
Compare
|
I added a commit to update the binaryen port to current master. This is needed since we have some flag changes for emcc to pass to binaryen (importing memory, no need to mappedGlobals). This would only affect users that did not set |
|
No, this looks fine. |
|
Cool, thanks. |
This branch works together with binaryen's
stackbranch in WebAssembly/binaryen#678. We should merge them only together.Nothing major here, just mem init file improvements (as binaryen can now import it into asm2wasm modules) and some fuzzing improvements.