Skip to content

fix: fixed mirroring not working #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Conversation

egbakou
Copy link
Contributor

@egbakou egbakou commented Mar 1, 2025

Mirroring is currently broken in version v9.0.313, as reported here #478

The issue is caused by a NullReferenceException in ResourceMirror.cs#L328. It seems like the client gets disposed. There might be an issue with how service lifetimes and DI are managed.

@winromulus I was able to reproduce this issue through the integration tests I am currently writing. I will submit a separate PR for the tests.

Fixes: #478

@winromulus winromulus merged commit 4f19183 into emberstack:main Mar 1, 2025
2 checks passed
@winromulus
Copy link
Contributor

@egbakou - Merged this for now but I'm doing major reworking on reflector in the next few days. Thanks for the fast fix.

@egbakou
Copy link
Contributor Author

egbakou commented Mar 1, 2025

Thanks for merging. Let me know if I can help with anything :)

@tamohamm96
Copy link

Hi Team,

We’re currently facing an issue where syncing works as expected for standard Kubernetes secrets created via Helm charts or Terraform. However, secrets generated by the Strimzi operator are not syncing reliably.

After the related PR was merged, we upgraded the Reflector Helm chart from v7.1.288 to v9.0.322. While the initial creation of Strimzi-generated secrets is successfully reflected to the destination namespace, any subsequent updates made by the Strimzi operator are not being propagated.

Could you please look into this or let us know if any additional configuration is needed?

used annotations:

      reflector.v1.k8s.emberstack.com/reflection-allowed: "true"
      reflector.v1.k8s.emberstack.com/reflection-auto-enabled: "true"
      reflector.v1.k8s.emberstack.com/reflection-auto-namespaces: clickhouse

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Using version v9.0.313 of reflector does not mirror the secrets.
3 participants