Skip to content

Replace ember-cli-tailwind with postcss and tailwindcss #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josemarluedke
Copy link
Contributor

Fixes #407.

cc/ @samselikoff @rwwagner90

@samselikoff Thanks for the video on EmberMap on this migration, that really helped.

@josemarluedke josemarluedke force-pushed the remove-ember-cli-tailwind branch from e8ba646 to 38e6b84 Compare October 18, 2019 00:18
@RobbieTheWagner
Copy link
Member

Thanks so much for the PR @josemarluedke! @samselikoff let me know if everything looks okay to you, and we can merge

@samselikoff
Copy link
Contributor

Awesome work @josemarluedke! Thanks for doing all this work!

Future PR idea: wonder if there's a way for us to distribute just the dist of this tailwind build into the final host apps. No reason for docs apps to have to pay the build-time cost of compiling this every time. Would be amazing to just ship the built (+ even purged!) tailwind docs styles.

@samselikoff samselikoff merged commit e770ce8 into ember-learn:master Oct 18, 2019
@alexlafroscia
Copy link
Contributor

wonder if there's a way for us to distribute just the dist of this tailwind build into the final host apps

This would also solve the issue of #406, where the addon's instance of Tailwind and the ember-cli-addon-docs instance are conflicting.

@nadnoslen
Copy link

Thank you for this!
thanks

@ef4
Copy link
Contributor

ef4 commented Dec 31, 2019

It would be good to get this released. I think without it addon-docs is generating invalid CSS for anyone on ember-cli >= 3.13.

@NullVoxPopuli
Copy link

I think this PR broke default styles.
See: #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom brand color no longer works in Ember CLI 3.13
7 participants