feat(nsis): terminate only processes running in installation folder #9069
Conversation
🦋 Changeset detectedLatest commit: 4ee668a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panther7
force-pushed
the
nsis-kill-process
branch
from
46904f1 to
370ff74
Compare
|
@beyondkmp would you mind taking a look at this when you have a chance? |
packages/app-builder-lib/templates/nsis/include/allowOnlyOneInstallerInstance.nsh
Outdated
Show resolved
Hide resolved
panther7
force-pushed
the
nsis-kill-process
branch
from
370ff74 to
50e8b45
Compare
Modified the process termination logic in NSIS scripts to only kill application processes that are running from the installation directory. This prevents accidental termination of processes with the same name running from other locations during installation or update.
panther7
force-pushed
the
nsis-kill-process
branch
from
50e8b45 to
d937699
Compare
|
@panther7 following up here, what tests have you run so far? Wondering if we can create an install+update test somehow for this in GHA runner? Similar to how this works: https://github.com/electron-userland/electron-builder/pull/9113/files?diff=unified&w=1#diff-1d9441830c74b56db3ecc46ef9805c4519141c15e145fabb24159d86e49d526dR10-R31 |
|
Working on a full "blackbox" test suite for verifying installation and updater flows with native/non-mocked Updaters Will get that functional and then pull it into this PR for you so that we can add a black-box test for this |
Modified the process termination logic in NSIS scripts to only kill application processes that are running from the installation directory. This prevents accidental termination of processes with the same name running from other locations during installation or update.
issue: #9009