Remove APIs that do not exist on serverless #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The errors are not related to this pull request. Well, except from: > await async_client.cluster.health(wait_for_status="yellow")
E AttributeError: 'ClusterClient' object has no attribute 'health'but I would still like to fix it later. |
JoshMock
approved these changes
Apr 8, 2024
It's not specific to serverless. If we removed a namespace in stack, we would see the same issue. We can discuss more in the codegen PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code generator is only additive, which meant it never removed APIs that were marked as not available on serverless.