Ensure optional dependencies are optional #2508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orjson is an optional dependency, but I was checking its absence with
ModuleNotFoundError
, a child exception ofImportError
. Whileimport orjson
will indeed raiseModuleNotFoundError
,from .serializer import OrjsonSerializer
raisesImportError
instead because the module (.serializer
) was found.OpenTelemetry is already tested in separate integration tests, but checking it explicitly in lint seemed useful as it's only one more line.