Use path_prefix to compute base_url in httpx #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
path_prefix
configuration (i.e. the url path) of the ES host is removed by the httpx client. This PR adds it.path_prefix
is set byclient_utils.url_to_node_config
(https://github.com/elastic/elastic-transport-python/blob/main/elastic_transport/client_utils.py#L187). It is either""
if the url path is empty or"/"
, or the url path itself.For example, if you configure host to be
http://localhost:9092/test
and run a search() query, you'll see an HTTP request sent tohttp://localhost:9092/_search
, without the "test" prefix.This is very useful when elastic endpoints are behind a reverse proxy with a specific path.