Skip to content

Only add executable to extensions/ #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

Only add executable to extensions/ #216

merged 1 commit into from
Jun 9, 2022

Conversation

axw
Copy link
Member

@axw axw commented Jun 9, 2022

The extensions directory must only contain executable extensions.
Add NOTICE.txt and dependencies.asciidoc to the top level of the
zip, rather than in the extensions directory.

@axw
Only add executable to extensions/
33473ae 
The extensions directory must only contain executable extensions.
Add NOTICE.txt and dependencies.asciidoc to the top level of the
zip, rather than in the extensions directory.
@axw axw requested a review from a team June 9, 2022 03:15
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 9, 2022
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-09T03:15:31.914+0000

  • Duration: 9 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 216
Skipped 4
Total 220

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

lahsivjar
lahsivjar approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axw axw merged commit de46a01 into elastic:main Jun 9, 2022
@axw axw deleted the fix-notice-extensions branch June 9, 2022 06:02
jlvoiseux pushed a commit that referenced this pull request Jun 9, 2022
@axw @jlvoiseux
Only add executable to extensions/ (#216)
fb33779 
The extensions directory must only contain executable extensions.
Add NOTICE.txt and dependencies.asciidoc to the top level of the
zip, rather than in the extensions directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahsivjar lahsivjar lahsivjar approved these changes

Assignees
No one assigned
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axw @apmmachine @lahsivjar