Skip to content

Generate NOTICE.txt and dependencies.asciidoc #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 3, 2022
Merged

Conversation

stuartnelson3
Copy link
Contributor

  • add script to generate NOTICE.txt and dependencies.asciidoc
  • generate NOTICE.txt and dependencies.asciidoc
  • check they are up-to-date in ci

closes #197

@stuartnelson3 stuartnelson3 requested review from v1v, jlvoiseux and a team and removed request for v1v June 3, 2022 08:02
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 3, 2022
Foundation (http://www.apache.org/).

{{ "=" | line }}
Third party libraries used by the Elastic APM AWS Lambda extension.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if Elastic APM AWS Lambda extension should be something else

Copy link
Contributor

@jlvoiseux jlvoiseux Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this ! I tend to use Elastic APM Lambda Extension, as the name of the Go package is apm-lambda-extension. It is also the name widely used in our first blog post on the subject. However, I am aware this convention is not strictly applied everywhere, which can make things confusing.

@apmmachine
Copy link

apmmachine commented Jun 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-03T12:59:33.951+0000

  • Duration: 7 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 196
Skipped 4
Total 200

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlvoiseux
Copy link
Contributor

Thank you for this, LGTM, aside from the name of the extension

Co-authored-by: Jean-Louis Voiseux <48380853+jlvoiseux@users.noreply.github.com>
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the last bit with the naming. Please wait with merging it in until @gtback also gave it a quick review.

Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co>
@simitt
Copy link
Contributor

simitt commented Jun 3, 2022

@stuartnelson3 I actually just run make but the license wasn't updated. Can you ensure to also include the update into the regular make and build process?
It looks like you only hoooked up the check that the license is up to date with Jenkins.

@simitt simitt mentioned this pull request Jun 3, 2022
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rename LICENSE to LICENSE.txt

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stuart!

@stuartnelson3 stuartnelson3 merged commit e9904a2 into main Jun 3, 2022
@stuartnelson3 stuartnelson3 deleted the generate-notice branch June 3, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automation for keeping the NOTICE file up-to-date
4 participants