-
Notifications
You must be signed in to change notification settings - Fork 31
Generate NOTICE.txt and dependencies.asciidoc #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scripts/templates/NOTICE.txt.tmpl
Outdated
Foundation (http://www.apache.org/). | ||
|
||
{{ "=" | line }} | ||
Third party libraries used by the Elastic APM AWS Lambda extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if Elastic APM AWS Lambda extension
should be something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this ! I tend to use Elastic APM Lambda Extension
, as the name of the Go package is apm-lambda-extension
. It is also the name widely used in our first blog post on the subject. However, I am aware this convention is not strictly applied everywhere, which can make things confusing.
Thank you for this, LGTM, aside from the name of the extension |
Co-authored-by: Jean-Louis Voiseux <48380853+jlvoiseux@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the last bit with the naming. Please wait with merging it in until @gtback also gave it a quick review.
Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co>
@stuartnelson3 I actually just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also rename LICENSE
to LICENSE.txt
we're generating the notice, not the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Stuart!
closes #197