Don't invoke continuations inline in OnCompleted #12261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
halter73
force-pushed
the
halter73/taskrun-oncompleted-continuations
branch
from
c2e7b11 to
fee23ca
Compare
|
The Linuv one seems unnecessary. And if it happens we should queue to the uv thread |
Good catch. If the next call to FromApplicationPipeReader.ReadAsync in LibuvOutputConsumer.WriteOutputAsync returned a completed ValueTask, we could end up calling uv_write on a random threadpool thread. I don't have a reference to the LibuvThread in LibuvAwaitable. I could plumb it through, or I could just do a Debug.Assert(false) or something and not call the continuation at all. |
halter73
force-pushed
the
halter73/taskrun-oncompleted-continuations
branch
from
ead7f5e to
a65f06b
Compare
|
I did the Debug.Assert thing and got rid of the Interlocked.CompareExchange in LibuvAwaitable since everything is called from the same thread anyway. |
halter73
force-pushed
the
halter73/taskrun-oncompleted-continuations
branch
from
a65f06b to
8a7334e
Compare
davidfowl
reviewed
Jul 17, 2019
src/Servers/Kestrel/Transport.Libuv/src/Internal/LibuvAwaitable.cs
Outdated
Show resolved
Hide resolved
davidfowl
approved these changes
Jul 17, 2019
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be impossible for LibuvAwaitable anyway since both OnCompleted and its Callback property are always invoked from the same thread.