[2.0] Silk.NET on Android #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. Note that I haven't given this the self review I usually do yet. |
HurricanKai
requested changes
Oct 26, 2020
|
Afaik Xamarin doesn't work properly on Linux, the image on which CI runs. |
|
Could make a separate mobile CI (that maybe only triggers in some cases) on Windows |
|
Could do, however it'd be best to be done around the same time that #308 is done. |
|
Sure, works for me. |
Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
|
Donezo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Allows Silk.NET to run on Android. Requires a Java and C shim.
Related issues, Discord discussions, or proposals
#48
Further Comments
NUKE would really come in handy linking all the build systems at play here. Future prospect though, and I'm happy for #308 to be assigned to me.