Skip to content

[2.0] SDL bindings #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 8, 2020
Merged

[2.0] SDL bindings #264

merged 8 commits into from
Aug 8, 2020

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Aug 7, 2020

Summary of the PR

Adds SDL bindings.

Related issues, Discord discussions, or proposals

#211
#48

Further Comments

This is a precursor to a subsequent PR containing a SDL windowing backend.

@Perksey
Copy link
Member Author

Perksey commented Aug 7, 2020

Ready for review. Notes for review:

  • There are some anonymous structs I haven't had the chance to give names yet. Ideally they should get names at some point during the preview cycle, but they're luckily only for one of the lesser-used headers of SDL.
  • Some binder changes were made.
  • The rest of the PR is pretty much just generated code so it should be fairly easy to review.

Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a SDL submodule instead of all those files https://github.com/spurious/SDL-mirror

@Perksey
Copy link
Member Author

Perksey commented Aug 8, 2020

Ready for re-review.

@Perksey Perksey merged commit d4c4152 into 2.0 Aug 8, 2020
@Perksey Perksey deleted the feature/sdl-bindings branch August 8, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants