Skip to content

[WIP] Maths Tests & Final API #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 20, 2020
Merged

[WIP] Maths Tests & Final API #242

merged 24 commits into from
Jul 20, 2020

Conversation

HurricanKai
Copy link
Member

No description provided.

@HurricanKai HurricanKai marked this pull request as ready for review July 15, 2020 16:54
@HurricanKai
Copy link
Member Author

not ready for review, but this includes CI changes

@codecov
Copy link

codecov bot commented Jul 19, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feature/maths@165d45b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             feature/maths     #242   +/-   ##
================================================
  Coverage                 ?   18.90%           
================================================
  Files                    ?       22           
  Lines                    ?     3126           
  Branches                 ?      473           
================================================
  Hits                     ?      591           
  Misses                   ?     2532           
  Partials                 ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165d45b...bd886be. Read the comment docs.

@HurricanKai HurricanKai requested a review from Perksey as a code owner July 20, 2020 14:02
Perksey
Perksey approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge to continue work off the main branch.

@HurricanKai HurricanKai merged commit e4faecb into dotnet:feature/maths Jul 20, 2020
@HurricanKai HurricanKai deleted the feature/matrices branch July 20, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
area-Maths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HurricanKai @Perksey