Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres a ton of changes in there, but the Code-critical ones are:
Scalar
types,Scalar<T>
for Properties that forward toScalar<T>
, andScalar<T>
for actual implementationsScalar
has a new important pattern added to it.Scalar
changes should always be checked with JIT to prevent unnecessarycall
s, a comment in regards to this has been added.Note that git is really bad at picking up on the actual changes, in many cases
Scalar<T>
has either been removed or replaced withScalar
but that combined with some formatting changes leads to git just marking it as one huge difference.Also note that I've used
using static Silk.NET.Maths.Scalar;
everywhere, eliminating any possible explicitScalar
s (note that when there is a local method named the same as theScalar
method theScalar
method cannot be used without explicitly specifyingScalar
, I'd overall suggestusing static Silk.NET.Maths.Scalar;
since there are nearly no uses were it isn't clear what the function means without theScalar
prefix)