Skip to content

Scalar2 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Scalar2 #200

merged 3 commits into from
Jun 20, 2020

Conversation

HurricanKai
Copy link
Member

@HurricanKai HurricanKai commented Jun 20, 2020

Theres a ton of changes in there, but the Code-critical ones are:

  • .editorconfig has been slightly altered
  • there are now two Scalar types, Scalar<T> for Properties that forward to Scalar<T>, and Scalar<T> for actual implementations
  • code cleanup has been run, making some code worse, but overall consistency is better.
  • Scalar has a new important pattern added to it.
  • Scalar changes should always be checked with JIT to prevent unnecessary calls, a comment in regards to this has been added.

Note that git is really bad at picking up on the actual changes, in many cases Scalar<T> has either been removed or replaced with Scalar but that combined with some formatting changes leads to git just marking it as one huge difference.

Also note that I've used using static Silk.NET.Maths.Scalar; everywhere, eliminating any possible explicit Scalars (note that when there is a local method named the same as the Scalar method the Scalar method cannot be used without explicitly specifying Scalar, I'd overall suggest using static Silk.NET.Maths.Scalar; since there are nearly no uses were it isn't clear what the function means without the Scalar prefix)

@HurricanKai
Copy link
Member Author

@Perksey please review (I don't think it's necessary to review files besides Scalar / possibly ScalarTests, since the others are only find-and-replace and code cleanup)

@Perksey Perksey merged commit d6c9f94 into dotnet:feature/maths Jun 20, 2020
@HurricanKai HurricanKai deleted the maths/scalar2 branch June 20, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants